Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opt(schema): Optimize populateSchema() by avoiding repeated lock acquisition #8068

Merged
merged 1 commit into from
Oct 4, 2021
Merged

opt(schema): Optimize populateSchema() by avoiding repeated lock acquisition #8068

merged 1 commit into from
Oct 4, 2021

Conversation

ahsanbarkati
Copy link
Contributor

@ahsanbarkati ahsanbarkati commented Oct 4, 2021 •
edited by manishrjain
Loading

Optimize populateSchema() by avoiding repeated lock acquisition,
we can get the schema for the predicate once and then check for
the required field.

This change is Reviewable

NamanJain8
NamanJain8 approved these changes Oct 4, 2021
View reviewed changes
Copy link
Contributor

@NamanJain8 NamanJain8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ahsanbarkati ahsanbarkati merged commit d935b8b into master Oct 4, 2021
@ahsanbarkati ahsanbarkati deleted the ahsan/populate-schema branch October 4, 2021 15:02
NamanJain8 pushed a commit that referenced this pull request Oct 5, 2021
@ahsanbarkati @NamanJain8
opt(schema): Optimize populateSchema() by avoiding repeated lock acqu…
aae19eb 
…isition (#8068)

Optimize populateSchema() by avoiding repeated lock acquisition.
we can get the schema for the predicate once and then check for
the required field without taking a read lock.

(cherry picked from commit d935b8b)
@NamanJain8 NamanJain8 mentioned this pull request Oct 5, 2021
Merged
ahsanbarkati added a commit that referenced this pull request Oct 5, 2021
@NamanJain8 @ahsanbarkati
opt(schema): Optimize populateSchema() by avoiding repeated lock acqu…
721d7d9 
…isition (#8068) (#8071)

Optimize populateSchema() by avoiding repeated lock acquisition.
we can get the schema for the predicate once and then check for
the required field without taking a read lock.

(cherry picked from commit d935b8b)

Co-authored-by: Ahsan Barkati <ahsan@dgraph.io>
mangalaman93 pushed a commit that referenced this pull request Jan 4, 2023
@NamanJain8 @mangalaman93
opt(schema): Optimize populateSchema() (#8068) (#8071)
9aba59e 
Optimize populateSchema() by avoiding repeated lock acquisition.
we can get the schema for the predicate once and then check for
the required field without taking a read lock.

(cherry picked from commit d935b8b)
mangalaman93 added a commit that referenced this pull request Jan 6, 2023
@mangalaman93
opt(schema): Optimize populateSchema() (#8068) (#8071) (#8565)
b74f612 
Optimize populateSchema() by avoiding repeated lock acquisition. we can
get the schema for the predicate once and then check for the required
field without taking a read lock.

(cherry picked from commit d935b8b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NamanJain8 NamanJain8 NamanJain8 approved these changes

@manishrjain manishrjain Awaiting requested review from manishrjain

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahsanbarkati @NamanJain8