Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opt(schema): Optimize populateSchema() by avoiding repeated lock acqu… #8071

Merged
merged 1 commit into from
Oct 5, 2021
Merged

opt(schema): Optimize populateSchema() by avoiding repeated lock acqu… #8071

merged 1 commit into from
Oct 5, 2021

Conversation

NamanJain8
Copy link
Contributor

@NamanJain8 NamanJain8 commented Oct 5, 2021 •
edited by manishrjain
Loading

…isition (#8068)

Optimize populateSchema() by avoiding repeated lock acquisition.
we can get the schema for the predicate once and then check for
the required field without taking a read lock.

(cherry picked from commit d935b8b)

This change is Reviewable

@ahsanbarkati @NamanJain8
opt(schema): Optimize populateSchema() by avoiding repeated lock acqu…
aae19eb 
…isition (#8068)

Optimize populateSchema() by avoiding repeated lock acquisition.
we can get the schema for the predicate once and then check for
the required field without taking a read lock.

(cherry picked from commit d935b8b)
@ahsanbarkati ahsanbarkati merged commit 721d7d9 into release/v21.03-slash Oct 5, 2021
@ahsanbarkati ahsanbarkati deleted the naman/cp/schema-lock-pop branch October 5, 2021 14:58
mangalaman93 pushed a commit that referenced this pull request Jan 4, 2023
@NamanJain8 @mangalaman93
opt(schema): Optimize populateSchema() (#8068) (#8071)
9aba59e 
Optimize populateSchema() by avoiding repeated lock acquisition.
we can get the schema for the predicate once and then check for
the required field without taking a read lock.

(cherry picked from commit d935b8b)
mangalaman93 added a commit that referenced this pull request Jan 6, 2023
@mangalaman93
opt(schema): Optimize populateSchema() (#8068) (#8071) (#8565)
b74f612 
Optimize populateSchema() by avoiding repeated lock acquisition. we can
get the schema for the predicate once and then check for the required
field without taking a read lock.

(cherry picked from commit d935b8b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahsanbarkati ahsanbarkati ahsanbarkati approved these changes

@manishrjain manishrjain Awaiting requested review from manishrjain

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NamanJain8 @ahsanbarkati