correct "Blade Runner" uid. #1347
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because it must be done.
|
|
|
The UIDs change frequently because we delete and reload the entire data every time we make a release. There's no guarantee that the same entity would get the same UID. So, this change isn't useful. I'd recommend reverting the PR. Reviewed 1 of 1 files at r1. Comments from Reviewable |
jarifibrahim
pushed a commit
that referenced
this pull request
Jun 16, 2020
This commit brings the following changes from badger c45d966 Fix assert in background compression and encryption. (#1366) 14386ac GC: Consider size of value while rewriting (#1357) b2267c2 Restore: Account for value size as well (#1358) b762832 Tests: Do not leave behind state goroutines (#1349) 056d859 Support disabling conflict detection (#1344) fd89894 Compaction: Expired keys and delete markers are never purged (#1354) 543f353 Fix build on golang tip (#1355) a7e239e StreamWriter: Close head writer (#1347) da80eb9 Iterator: Always add key to txn.reads (#1328) 7e19cac Add immudb to the project list (#1341) 079f5ae DefaultOptions: Set KeepL0InMemory to false (#1345)
jarifibrahim
pushed a commit
that referenced
this pull request
Jun 17, 2020
This commit brings the following changes from badger ``` c45d966 Fix assert in background compression and encryption. (#1366) 14386ac GC: Consider size of value while rewriting (#1357) b2267c2 Restore: Account for value size as well (#1358) b762832 Tests: Do not leave behind state goroutines (#1349) 056d859 Support disabling conflict detection (#1344) fd89894 Compaction: Expired keys and delete markers are never purged (#1354) 543f353 Fix build on golang tip (#1355) a7e239e StreamWriter: Close head writer (#1347) da80eb9 Iterator: Always add key to txn.reads (#1328) 7e19cac Add immudb to the project list (#1341) 079f5ae DefaultOptions: Set KeepL0InMemory to false (#1345) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because it must be done.
This change is