Fix up predicate snapshot #2487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 19, 2019
Fix up both the way we create a snapshot and the way we stream it. Make the logic robust and add tests to ensure that the calculation of snapshot is right. Streaming no longer needs to worry about `min_ts`. We no longer send a snapshot upfront. Raft would request it as it desires, and the follower sends the snapshot details it needs from the leader. The leader in turn checks if its snapshot matches with what the follower wants. This is a better logic, but not entirely foolproof (comment in predicate.go explains). Bring in Badger changes, which add a `DropAll` method, which is called before applying the snapshot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix up both the way we create a snapshot and the way we stream it. Make the logic robust and add tests to ensure that the calculation of snapshot is right.
Streaming no longer needs to worry about
min_ts. We no longer send a snapshot upfront. Raft would request it as it desires, and the follower sends the snapshot details it needs from the leader. The leader in turn checks if its snapshot matches with what the follower wants. This is a better logic, but not entirely foolproof (comment in predicate.go explains).Bring in Badger changes, which add a
DropAllmethod, which is called before applying the snapshot.This change is