Optimize has function #2724
Merged
Optimize has function #2724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…must have at least some elements to be present.
…IsEmpty func in posting/list.go
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 19, 2019
Since the last change to make `has(...)` function to work correctly with transactions, things have been slow due to the need to build the entire posting list to determine if it has a posting or not. This PR optimizes that by utilizing BitCompletePosting. If this bit is found, then there must be a valid posting in the list, so we don't need to recreate the entire list. This speeds up `handleHasFunction` considerably, for all predicates which don't have `@lang` index. For the predicates which have the lang index set, they're slowed down by `filterStringFunction`, but there's no easy fix there. Added a TODO for that. Partially fixes dgraph-io#2533 for preds which don't have `@lang` index. Changelog: * No need to retrieve posting list if we have the complete bit set. It must have at least some elements to be present. * Understand the cause of slowdown, i.e. filterStringFunction. Improve IsEmpty func in posting/list.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the last change to make
has(...)function to work correctly with transactions, things have been slow due to the need to build the entire posting list to determine if it has a posting or not. This PR optimizes that by utilizing BitCompletePosting. If this bit is found, then there must be a valid posting in the list, so we don't need to recreate the entire list.This speeds up
handleHasFunctionconsiderably, for all predicates which don't have@langindex. For the predicates which have the lang index set, they're slowed down byfilterStringFunction, but there's no easy fix there. Added a TODO for that.This change is