Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go modules support. #2822

Closed
wants to merge 3 commits into from
Closed

Go modules support. #2822

wants to merge 3 commits into from

Conversation

srfrog
Copy link
Contributor

@srfrog srfrog commented Dec 14, 2018 •
edited
Loading

This PR adds go.mod and locks tracks dependencies with go.sum. Effectively removing the need for the vendor dir.

The first time a build is ran go will fetch and cache all dependencies in $GOPATH/pkg/mod, from then on, that cache is updated.

Go modules requires version 1.11.x or better.

This change is Reviewable

@srfrog srfrog added in progress kind/enhancement Something could be better. labels Dec 20, 2018
@srfrog srfrog closed this Feb 8, 2019
@srfrog srfrog deleted the srfrog/gomod branch February 8, 2019 01:00
@KarthikNayak
Copy link

@srfrog why was this dropped?

@mangalaman93 mangalaman93 mentioned this pull request Oct 8, 2019
Closed
@alexkreidler
Copy link

alexkreidler commented Oct 16, 2019 •
edited
Loading

For future reference, this was implemented and merged in with #4146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind/enhancement Something could be better.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@srfrog @KarthikNayak @alexkreidler