Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Remove lin_read usage from Raw HTTP client guide #2823

Merged
merged 5 commits into from
Dec 18, 2018
Merged

docs: Remove lin_read usage from Raw HTTP client guide #2823

merged 5 commits into from
Dec 18, 2018

Conversation

danielmai
Copy link
Contributor

@danielmai danielmai commented Dec 14, 2018 •
edited by manishrjain
Loading

  • Remove lin_read usage from Raw HTTP guide
  • Add in preds field.
  • Update keys in example mutation response since they seem to be in a different format now compared to what was written before.
  • Update transaction aborted error message.

This change is Reviewable

@danielmai
Copy link
Contributor Author

@mrjn can you review these new docs for the preds field?

manishrjain
manishrjain approved these changes Dec 14, 2018
View reviewed changes
Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Some comments.

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @danielmai)

wiki/content/clients/index.md, line 406 at r1 (raw file):

  
2. The set of keys modified by the transaction (`keys`). This aids in
   transaction conflict detection.

Every mutation would send back a new set of keys. The client must merge them with the existing set. Optionally, a client can de-dup these keys while merging.

wiki/content/clients/index.md, line 409 at r1 (raw file):

3. The set of predicates modified by the transaction (`preds`). This aids in
   predicate move detection. This only appears in clusters with multiple Alphas.

preds should always get filled in, and should be sent.

@danielmai
Copy link
Contributor Author

wiki/content/clients/index.md, line 409 at r1 (raw file):

Previously, manishrjain (Manish R Jain) wrote…

preds should always get filled in, and should be sent.

Done.

@danielmai
Copy link
Contributor Author

wiki/content/clients/index.md, line 406 at r1 (raw file):

Previously, manishrjain (Manish R Jain) wrote…

Every mutation would send back a new set of keys. The client must merge them with the existing set. Optionally, a client can de-dup these keys while merging.

Done.

@danielmai danielmai merged commit d71ecc8 into master Dec 18, 2018
@danielmai danielmai deleted the danielmai/docs_remove_lin_read branch December 18, 2018 23:34
danielmai added a commit that referenced this pull request Dec 18, 2018
@danielmai
docs: Remove lin_read usage from client implementation guide. (#2823)
eabcdeb 
* Remove lin_read from client docs.
* Add info about preds field.
* Show example of preds field in mutation.
dna2github pushed a commit to dna2fork/dgraph that referenced this pull request Jul 19, 2019
@danielmai @dna2github
docs: Remove lin_read usage from client implementation guide. (dgraph…
12e0d5c 
…-io#2823)

* Remove lin_read from client docs.
* Add info about preds field.
* Show example of preds field in mutation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manishrjain manishrjain manishrjain approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielmai @manishrjain