ValidateAddress should return true if IPv6 is valid #3027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add tests for ValidateAddress function Fixes dgraph-io#3023 Signed-off-by: Ibrahim Jarif <jarifibrahim@gmail.com>
jarifibrahim
commented
Feb 17, 2019
martinmr
approved these changes
Feb 19, 2019
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @jarifibrahim)
x/x.go, line 282 at r1 (raw file):
Previously, jarifibrahim (Ibrahim Jarif) wrote…
ParseIP returns nil if the IP address is invalid. See https://golang.org/pkg/net/#ParseIP
Ok.
x/x_test.go, line 68 at r1 (raw file):
Previously, jarifibrahim (Ibrahim Jarif) wrote…
I am not sure if this test should return true. Is this the intended behaviour?
A similar test on IPv6 returns false (see https://github.com/dgraph-io/dgraph/pull/3027/files#diff-12d9d50e4e8f838a59b4ad0e7ad05251R87)
I think it's fine for now. We could try to validate the hostname but that would most likely involve importing a library to do it and it's a bit overkill.
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 19, 2019
- Add tests for ValidateAddress function Fixes dgraph-io#3023 Signed-off-by: Ibrahim Jarif <jarifibrahim@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3023
This change is