Fix bug for queries with @recurse and expand(_all_). #3179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently this type of queries might result in an unrecoverable error in the alpha. This happens for example, while trying to expand on a node of type PASSWORD. The reason is that handleValuePostings and handleUidPostings sometimes successfully return early without setting the UidMatrix field. This change adds a fix and modifies the existing test to trigger this case. I have verified that the test crashes the alpha when the fix is absent.
manishrjain
approved these changes
Mar 20, 2019
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
danielmai
pushed a commit
that referenced
this pull request
Apr 12, 2019
Currently this type of queries might result in an unrecoverable error in the alpha. This happens for example, while trying to expand on a node of type PASSWORD. The reason is that handleValuePostings and handleUidPostings sometimes successfully return early without setting the UidMatrix field. This change adds a fix and modifies the existing test to trigger this case. I have verified that the test crashes the alpha when the fix is absent. (cherry picked from commit 3081fc1) - Removed common_test.go conflict - Removed sg.UnknownAttr check that's only in master.
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 19, 2019
Currently this type of queries might result in an unrecoverable error in the alpha. This happens for example, while trying to expand on a node of type PASSWORD. The reason is that handleValuePostings and handleUidPostings sometimes successfully return early without setting the UidMatrix field. This change adds a fix and modifies the existing test to trigger this case. I have verified that the test crashes the alpha when the fix is absent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently this type of queries might result in an unrecoverable error
in the alpha. This happens for example, while trying to expand on a node
of type PASSWORD.
The reason is that handleValuePostings and handleUidPostings sometimes
successfully return early without setting the UidMatrix field.
This change adds a fix and modifies the existing test to trigger this
case. I have verified that the test crashes the alpha when the fix is
absent.
Fixes #3161
This change is