Add timestamps during bulk/live load

[codexnull]

Add timestamps to make it easer to correlate load logs with server logs

---

This change is 

[martinmr]

Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @codexnull)

---

dgraph/cmd/bulk/progress.go, line 79 at r1 (raw file):

func (p *progress) reportOnce() {
	mapEdgeCount := atomic.LoadInt64(&p.mapEdgeCount)
	timestamp := time.Now().Format("15:04:05Z0700")

Shouldn't be the timezone negative?

Also, the value is 7 during daylight savings time but is 8 the rest of the year. I would change it to 8 since that's supposed to be the "normal" time.

---

dgraph/cmd/live/batch.go, line 200 at r1 (raw file):

		rate := float64(counter.Nquads-last.Nquads) / period.Seconds()
		elapsed := time.Since(start).Round(time.Second)
		timestamp := time.Now().Format("15:04:05Z0700")

Same comment as in the bulk loader.

[gitlw]

I'm curious whether we can switch to glog so that timestamps are added automatically.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @codexnull)

[codexnull]

I'm in favor of using glog more but I don't think it is appropriate for these messages. The glog messages include process IDs and source file names and line numbers. They are meant for the developer. These timestamps are meant for the user.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @martinmr)

---

dgraph/cmd/bulk/progress.go, line 79 at r1 (raw file):

Previously, martinmr (Martin Martinez Rivera) wrote…

Shouldn't be the timezone negative?

Also, the value is 7 during daylight savings time but is 8 the rest of the year. I would change it to 8 since that's supposed to be the "normal" time.

The Z0700 is not an actual time zone. It's the place-holder for where the time zone should go when the time is formatted. And using "Z0700" instead of "-0700" just formats midnight UTC, for example, as "00:00:00Z" instead of "00:00:00-000".

---

dgraph/cmd/live/batch.go, line 200 at r1 (raw file):

Previously, martinmr (Martin Martinez Rivera) wrote…

Same comment as in the bulk loader.

Done.

[martinmr]

Reviewable status: complete! all files reviewed, all discussions resolved