Increase Alpha trace logs.

[danielmai]

This change bumps up the number of logs per span to capture all the events from Server.Query instead of getting truncated logs in the trace data of up to 64 of the latest annotations.

When I load the 21-million movie data set and run a query to get all the movies directed by Steven Spielberg, Jaeger shows 232 logs for the query. With this change, the logs would be truncated if there are more than 256 annotations in a single span, leaving us to the same problem of possibly losing valuable info for a query trace.

{
  director(func: allofterms(name@en, "steven spielberg")) {
    name@en
    director.film {
      name@en
      initial_release_date
      country {
        name@en
      }
      starring {
        performance.actor {
          name@en
        }
        performance.character {
          name@en
        }
      }
      genre {
        name@en
      }
    }
  }
}

---

This change is 

[dgraph-bot]

Approved. Sent from Pixel 2

…

On Tue, Jul 16, 2019, 6:07 PM Daniel Mai ***@***.***> wrote: This change bumps up the number of logs per span to capture all the events from Server.Query instead of getting truncated logs in the trace data of up to 64 of the latest annotations. When I load the 21-million movie data set and run a query to get all the movies directed by Steven Spielberg, Jaeger shows 232 logs for the query. With this change, the logs would be truncated if there are more than 256 annotations in a single span, leaving us to the same problem of possibly losing valuable info for a query trace. { director(func: ***@***.***, "steven spielberg")) { ***@***.*** director.film { ***@***.*** initial_release_date country { ***@***.*** } starring { performance.actor { ***@***.*** } performance.character { ***@***.*** } } genre { ***@***.*** } } } } [image: image] <https://user-images.githubusercontent.com/2251820/61339794-4996f700-a7f4-11e9-8c55-46c809e328b1.png> ------------------------------ You can view, comment on, or merge this pull request online at: #3679 Commit Summary - Increase Alpha trace logs. File Changes - *M* dgraph/cmd/alpha/run.go <https://github.com/dgraph-io/dgraph/pull/3679/files#diff-0> (2) Patch Links: - https://github.com/dgraph-io/dgraph/pull/3679.patch - https://github.com/dgraph-io/dgraph/pull/3679.diff — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#3679?email_source=notifications&email_token=AJATO5XDAST7XMES25V6R5TP7ZWDVA5CNFSM4IEJJAMKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4G7TNCXQ>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJATO5T44YQBJGOU62IBYALP7ZWDVANCNFSM4IEJJAMA> .

[gitlw]

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @manishrjain)

[danielmai]

Thanks @dgraph-bot 🤔 and @gitlw.