Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release/v1.0: Increase max trace logs per span in Alpha. #3886

Merged
merged 8 commits into from
Aug 30, 2019
Merged

release/v1.0: Increase max trace logs per span in Alpha. #3886

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1b47cfb
Increase max trace logs per span in Alpha. (#3679)
danielmai Jul 17, 2019
93afd9f
Lower memory requirement for load test.
Feb 21, 2019
cdb2ee9
Reduce required memory. (#3274)
codexnull Apr 9, 2019
beb6b8a
Remove missing 21million test from release/v1.0.
danielmai Aug 30, 2019
69a68db
test-bulk-schema: Fix test for non-interactive shell session.
danielmai Aug 30, 2019
7089cb8
Add comment to MaxAnnotationPerSpan.
danielmai Aug 30, 2019
0fc875e
Revert test changes.
danielmai Aug 30, 2019
a1a04eb
Merge branch 'release/v1.0' into danielmai/v1.0-opencensus-increase-m…
danielmai Aug 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions dgraph/cmd/alpha/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,6 +476,11 @@ func run() {
}
otrace.ApplyConfig(otrace.Config{
danielmai marked this conversation as resolved.
Show resolved Hide resolved
DefaultSampler: otrace.ProbabilitySampler(worker.Config.Tracing),
// MaxAnnotationEventsPerSpan is 32 by default. Increasing the limit to
// 256 is a good middle-ground between having enough to store the spans
// for most query traces and for memory usage of spans. Queries that
// generate more annotations than this limit will get truncated traces.
MaxAnnotationEventsPerSpan: 256,
})

// Posting will initialize index which requires schema. Hence, initialize
Expand Down