Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow @filter directive to be used with expand queries. #4404

Merged
merged 6 commits into from
Dec 18, 2019

Conversation

martinmr
Copy link
Contributor

@martinmr martinmr commented Dec 12, 2019

This PR introduces the new syntax @fitler(type(<type_name>). It filters the results
of the query to only follow edges of the graph of the given type.
This implies that scalar fields will not be included in the response.

Fixes #3904


This change is Reviewable

Copy link
Contributor

@manishrjain manishrjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 5 files at r1, 2 of 3 files at r2, 2 of 2 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @martinmr and @pawanrawal)

@martinmr martinmr merged commit 8d968ca into master Dec 18, 2019
@martinmr martinmr deleted the martinmr/filter-on-expand branch December 18, 2019 22:00
danielmai pushed a commit that referenced this pull request Jan 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Support filter on expand
3 participants