Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACL: Allow users to query data for their groups, username, and permissions #4774

Merged
merged 11 commits into from
Feb 14, 2020
Merged

ACL: Allow users to query data for their groups, username, and permissions #4774

merged 11 commits into from
Feb 14, 2020

Commits on Feb 14, 2020

  1. Allow users to query their info

    @animesh2049
    animesh2049 committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    822b2ae View commit details
    Browse the repository at this point in the history

  2. Add test

    @animesh2049
    animesh2049 committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    afc2b33 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into animesh2049/expose-user-info

    @animesh2049
    animesh2049 committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    d0dae83 View commit details
    Browse the repository at this point in the history

  4. Refactor code and modify test

    @animesh2049
    animesh2049 committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    3ca6b81 View commit details
    Browse the repository at this point in the history

  5. Refactor addUserFilter 

    addUserFilter should only work for graphql queries. Also non graphql
query in test to make sure it returns empty result for acl queryies.
    @animesh2049
    animesh2049 committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    ba0ce59 View commit details
    Browse the repository at this point in the history

  6. Fix error for oss

    @animesh2049
    animesh2049 committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    a08d2fe View commit details
    Browse the repository at this point in the history

  7. Refactor addUserFilterToQuery

    @animesh2049
    animesh2049 committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    d0f80ab View commit details
    Browse the repository at this point in the history

  8. Add test for filters involving acl predicates

    @animesh2049
    animesh2049 committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    f7b694f View commit details
    Browse the repository at this point in the history

  9. Address PR comments

    @animesh2049
    animesh2049 committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    5b16b15 View commit details
    Browse the repository at this point in the history

  10. Revert "Address PR comments" 

    Reverting this commit because updating pointers inside function
doesn't look a neat way. Method used earlier seems more appropriate.
This reverts commit 5b16b15.
    @animesh2049
    animesh2049 committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    1fbc6c1 View commit details
    Browse the repository at this point in the history

  11. Add comments

    @animesh2049
    animesh2049 committed Feb 14, 2020
    Configuration menu
    Copy the full SHA
    35beb56 View commit details
    Browse the repository at this point in the history