Add support for tinyint in migrate tool. #4842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinmr
approved these changes
Feb 24, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @mangalaman93 and @manishrjain)
arijitAD
commented
Feb 25, 2020
There was a problem hiding this comment.
I ran the migration tool manually to verify the schema and data.
Reviewable status:
vardhanapoorv
pushed a commit
that referenced
this pull request
Mar 3, 2020
* Add support for tinyint in migrate tool.
arijitAD
pushed a commit
that referenced
this pull request
Apr 22, 2020
* Add support for tinyint in migrate tool. (cherry picked from commit 87e1dcd)
danielmai
pushed a commit
that referenced
this pull request
Apr 22, 2020
* Add support for tinyint in migrate tool. (cherry picked from commit 87e1dcd)
danielmai
added a commit
that referenced
this pull request
Apr 22, 2020
This reverts commit 79c68dc. This was mistakenly cherry-picked to release/v1.2.2 instead of release/v1.2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4674
This change is