Throw errors returned by retrieveValuesAndFacets #4966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The condition in this case was causing most of the errors to be ignored. Verified that reading below the minTs throws an error now. Fixes #4958
martinmr
added a commit
that referenced
this pull request
Mar 18, 2020
The error was being ignored and an empty response was being written because the condition in a case statement didn't exclude errors not equal to nil or ErrNoValue. This caused reads below the rollup Ts to succeed with an empty response when they should throw an error. The bug was triggered by running Jepsen tests with incremental rollups enabled. Fixes #4958
martinmr
added a commit
that referenced
this pull request
Mar 18, 2020
The error was being ignored and an empty response was being written because the condition in a case statement didn't exclude errors not equal to nil or ErrNoValue. This caused reads below the rollup Ts to succeed with an empty response when they should throw an error. The bug was triggered by running Jepsen tests with incremental rollups enabled. Fixes #4958
martinmr
added a commit
that referenced
this pull request
Mar 18, 2020
The error was being ignored and an empty response was being written because the condition in a case statement didn't exclude errors not equal to nil or ErrNoValue. This caused reads below the rollup Ts to succeed with an empty response when they should throw an error. The bug was triggered by running Jepsen tests with incremental rollups enabled. Fixes #4958
martinmr
added a commit
that referenced
this pull request
Mar 18, 2020
The error was being ignored and an empty response was being written because the condition in a case statement didn't exclude errors not equal to nil or ErrNoValue. This caused reads below the rollup Ts to succeed with an empty response when they should throw an error. The bug was triggered by running Jepsen tests with incremental rollups enabled. Fixes #4958
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error was being ignored and an empty response was being written because the
condition in a case statement didn't exclude errors not equal to nil or ErrNoValue.
This caused reads below the rollup Ts to succeed with an empty response when
they should throw an error. The bug was triggered by running Jepsen tests with
incremental rollups enabled.
Fixes #4958
This change is