Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add xidmap and store_xids to documentation #5093

Merged
merged 2 commits into from
Apr 16, 2020
Merged

Conversation

MichelDiz
Copy link
Contributor

@MichelDiz MichelDiz commented Apr 3, 2020

Reference: #5090

Dear contributor, what does this PR do?

Updates documentation regarding Live and Bulk loaders features.

Motivation

There was no documentation for these features, although they are used by some people who understand how these features work.

Components affected by this PR

No

Does this PR break backwards compatibility?

No

Fixes

Closes #5049

More


This change is Reviewable

Docs Preview: Dgraph Preview

Also have added -x to Live and make xidmap default in comments.
Copy link
Contributor

@danielmai danielmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @MichaelJCompton and @MichelDiz)

@danielmai
Copy link
Contributor

Is this ready to merge, @MichelDiz ?

@MichelDiz
Copy link
Contributor Author

Yep, doing it now.

@MichelDiz MichelDiz merged commit 36ae378 into master Apr 16, 2020
@MichelDiz MichelDiz deleted the micheldiz/xidmapDocs branch April 16, 2020 21:07
danielmai pushed a commit that referenced this pull request May 1, 2020
* Add xidmap and store_xids to documentation

Reference: #5090

* Remove -x flag in bulk

Also have added -x to Live and make xidmap default in comments.
danielmai added a commit that referenced this pull request May 27, 2020
dna2github pushed a commit to dna2fork/dgraph that referenced this pull request Jul 18, 2020
* Add xidmap and store_xids to documentation

Reference: dgraph-io#5090

* Remove -x flag in bulk

Also have added -x to Live and make xidmap default in comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Documentation related issues.
Development

Successfully merging this pull request may close these issues.

Add docs for --store_xids and --xidmap flags
3 participants