Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update group checksums when combining multiple deltas. #5394

Merged
merged 2 commits into from
May 8, 2020
Merged

Update group checksums when combining multiple deltas. #5394

merged 2 commits into from
May 8, 2020

Commits on May 7, 2020

  1. Update group checksums when combining multiple deltas. 

    The function processing the oracle delta stream combines multiple deltas
into one to reduce the number of proposal. However, the group checksums
were not being updated, causing some group checksums update to be lost.

gRPC guarantees that the ordering of the deltas coming from the stream
so overwriting the group checksums is safe.

Tested by following the steps in #5368.

Fixes #5368
    @martinmr
    martinmr committed May 7, 2020
    Configuration menu
    Copy the full SHA
    a6b7eff View commit details
    Browse the repository at this point in the history

  2. Address review comments.

    @martinmr
    martinmr committed May 7, 2020
    Configuration menu
    Copy the full SHA
    648a0e4 View commit details
    Browse the repository at this point in the history