Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix alpha start in ludicrous mode #5642

Merged
merged 2 commits into from
Jul 8, 2020
Merged

Fix alpha start in ludicrous mode #5642

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
eec4225
Mark proposal done immediately only for data mutation
ashish-goswami Jun 12, 2020
45a2e30
Address review comments
ashish-goswami Jun 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions worker/draft.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1157,8 +1157,9 @@ func (n *node) Run() {
if span := otrace.FromContext(pctx.Ctx); span != nil {
span.Annotate(nil, "Proposal found in CommittedEntries")
}
if x.WorkerConfig.LudicrousMode {
// Assuming that there will be no error while proposing.
if x.WorkerConfig.LudicrousMode && len(proposal.Mutations.GetEdges()) > 0 {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipping ludicrous mode for schema mutations seems to be the right approach. If 'Getedges' is the right mechanism for identifying schema changes then it would be good to have a comment to describe our intent here.

// Assuming that there will be no error while applying. But this
// assumption is only made for data mutations and not schema mutations.
n.Proposals.Done(proposal.Key, nil)
}
}
Expand Down