Avoid panic in handleValuePostings #5652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashish-goswami
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
martinmr
approved these changes
Jun 15, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ashish-goswami, @manishrjain, and @vvbalaji-dgraph)
worker/task.go, line 365 at r1 (raw file):
Quoted 4 lines of code…
// calculate(). panic is of the form "index out of range [4] with length 1". We have tried to // reproduce this but couldn't find any edge case which will result in this panic. So for now // we are just logging when srcFn.n != len(q.UidList.Uids) and returning error when this // happens.
shorten this comment, you don't need the last part.
ashish-goswami
commented
Jun 16, 2020
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @manishrjain, @martinmr, and @vvbalaji-dgraph)
worker/task.go, line 365 at r1 (raw file):
Previously, martinmr (Martin Martinez Rivera) wrote…
// calculate(). panic is of the form "index out of range [4] with length 1". We have tried to // reproduce this but couldn't find any edge case which will result in this panic. So for now // we are just logging when srcFn.n != len(q.UidList.Uids) and returning error when this // happens.shorten this comment, you don't need the last part.
Done.
jarifibrahim
approved these changes
Jun 16, 2020
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @manishrjain, @martinmr, and @vvbalaji-dgraph)
ashish-goswami
added a commit
that referenced
this pull request
Jun 18, 2020
Fixes: DGRAPH-1608 srcFn.n should be equal to len(q.UidList.Uids) for implementation DivideAndRule and calculate to work correctly. But we have seen some panics while forming DataKey in calculate(). panic is of the form "index out of range [4] with length 1". We have tried to reproduce this but couldn't find any edge case which will result in this panic. So for now we are just logging when srcFn.n != len(q.UidList.Uids) and returning error when this happens. (cherry picked from commit 2184268)
danielmai
pushed a commit
that referenced
this pull request
Jun 18, 2020
Fixes: DGRAPH-1608 srcFn.n should be equal to len(q.UidList.Uids) for implementation DivideAndRule and calculate to work correctly. But we have seen some panics while forming DataKey in calculate(). panic is of the form "index out of range [4] with length 1". We have tried to reproduce this but couldn't find any edge case which will result in this panic. So for now we are just logging when srcFn.n != len(q.UidList.Uids) and returning error when this happens. (cherry picked from commit 2184268)
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 18, 2020
Fixes: DGRAPH-1608 srcFn.n should be equal to len(q.UidList.Uids) for implementation DivideAndRule and calculate to work correctly. But we have seen some panics while forming DataKey in calculate(). panic is of the form "index out of range [4] with length 1". We have tried to reproduce this but couldn't find any edge case which will result in this panic. So for now we are just logging when srcFn.n != len(q.UidList.Uids) and returning error when this happens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: DGRAPH-1608
srcFn.nshould be equal tolen(q.UidList.Uids)for implementationDivideAndRuleandcalculateto work correctly. But we have seen some panics while formingDataKeyincalculate(). panic is of the form"index out of range [4] with length 1". We have tried toreproduce this but couldn't find any edge case which will result in this panic. So for now
we are just logging when
srcFn.n != len(q.UidList.Uids)and returning error when thishappens.
This change is