Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(release/v20.07) test: fix flakiness in TestValQueryWithACLPermissions #6004

Merged
merged 3 commits into from
Aug 4, 2020
Merged

(release/v20.07) test: fix flakiness in TestValQueryWithACLPermissions #6004

merged 3 commits into from
Aug 4, 2020

Conversation

martinmr
Copy link
Contributor

@martinmr martinmr commented Jul 15, 2020 •
edited by dgraph-bot
Loading

Fixes DGRAPH-1914

(cherry picked from commit ef64048)

This change is Reviewable

Docs Preview: Dgraph Preview

@martinmr
test: fix flakiness in TestValQueryWithACLPermissions (#5978)
1b45a21 
Fixes DGRAPH-1914

(cherry picked from commit ef64048)
@github-actions github-actions bot added the area/enterprise Related to proprietary features label Jul 15, 2020
@sourya
Copy link

sourya commented Jul 15, 2020 •
edited
Loading

The DeepSource analysis on this PR has been timing out. It was an issue with a recent release. We have fixed the issue now, and retried the analysis.

Edit: The analysis also timed out for #6005 and #6006. They have been retried too. (I didn't want to clutter the conversation in all PRs).

all-seeing-code
all-seeing-code approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@all-seeing-code all-seeing-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @manishrjain)

all-seeing-code
all-seeing-code approved these changes Jul 29, 2020
View reviewed changes
Copy link
Contributor

@all-seeing-code all-seeing-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @manishrjain)

@martinmr martinmr merged commit 3cafe7a into release/v20.07 Aug 4, 2020
@martinmr martinmr deleted the martinmr/cp-acl07 branch August 4, 2020 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@all-seeing-code all-seeing-code all-seeing-code approved these changes

@manishrjain manishrjain Awaiting requested review from manishrjain

Assignees
No one assigned
Labels
area/enterprise Related to proprietary features
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martinmr @sourya @all-seeing-code