fix(ServeTask): Return error if server is not ready #6019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The grpcWorker.ServeTask function is called when a request is received over the network (sent by a peer). This function doesn't consider the health of the node before starting the processing of the request. If we process a request before the node is ready, we might end up seeing crashes similar to https://dgraph.atlassian.net/browse/DGRAPH-1934
jarifibrahim
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
martinmr
approved these changes
Jul 16, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @manishrjain and @vvbalaji-dgraph)
ashish-goswami
approved these changes
Jul 16, 2020
There was a problem hiding this comment.
Would be good to mention in the commit how you found it(jepsen test, nemesis).
Reviewable status:
jarifibrahim
changed the title
parasssh
approved these changes
Jul 16, 2020
There was a problem hiding this comment.
Reviewable status:
jarifibrahim
pushed a commit
that referenced
this pull request
Jul 16, 2020
The grpcWorker.ServeTask function is called when a request is received over the network (sent by a peer). This function doesn't consider the health of the node before starting the processing of the request. If we process a request before the node is ready, we might end up seeing crashes similar to https://dgraph.atlassian.net/browse/DGRAPH-1934 Fixes DGRAPH-1934 This bug was seen when running jepsen bank test with kill-alpha and kill-zero nemesis. (cherry picked from commit 9293c97)
jarifibrahim
pushed a commit
that referenced
this pull request
Jul 16, 2020
The grpcWorker.ServeTask function is called when a request is received over the network (sent by a peer). This function doesn't consider the health of the node before starting the processing of the request. If we process a request before the node is ready, we might end up seeing crashes similar to https://dgraph.atlassian.net/browse/DGRAPH-1934 Fixes DGRAPH-1934 This bug was seen when running jepsen bank test with kill-alpha and kill-zero nemesis. (cherry picked from commit 9293c97)
jarifibrahim
pushed a commit
that referenced
this pull request
Jul 16, 2020
The grpcWorker.ServeTask function is called when a request is received over the network (sent by a peer). This function doesn't consider the health of the node before starting the processing of the request. If we process a request before the node is ready, we might end up seeing crashes similar to https://dgraph.atlassian.net/browse/DGRAPH-1934 Fixes DGRAPH-1934 This bug was seen when running jepsen bank test with kill-alpha and kill-zero nemesis. (cherry picked from commit 9293c97)
parasssh
pushed a commit
that referenced
this pull request
Jul 16, 2020
The grpcWorker.ServeTask function is called when a request is received over the network (sent by a peer). This function doesn't consider the health of the node before starting the processing of the request. If we process a request before the node is ready, we might end up seeing crashes similar to https://dgraph.atlassian.net/browse/DGRAPH-1934 Fixes DGRAPH-1934 This bug was seen when running jepsen bank test with kill-alpha and kill-zero nemesis. (cherry picked from commit 9293c97)
parasssh
pushed a commit
that referenced
this pull request
Jul 16, 2020
The grpcWorker.ServeTask function is called when a request is received over the network (sent by a peer). This function doesn't consider the health of the node before starting the processing of the request. If we process a request before the node is ready, we might end up seeing crashes similar to https://dgraph.atlassian.net/browse/DGRAPH-1934 Fixes DGRAPH-1934 This bug was seen when running jepsen bank test with kill-alpha and kill-zero nemesis. (cherry picked from commit 9293c97)
parasssh
pushed a commit
that referenced
this pull request
Jul 16, 2020
The grpcWorker.ServeTask function is called when a request is received over the network (sent by a peer). This function doesn't consider the health of the node before starting the processing of the request. If we process a request before the node is ready, we might end up seeing crashes similar to https://dgraph.atlassian.net/browse/DGRAPH-1934 Fixes DGRAPH-1934 This bug was seen when running jepsen bank test with kill-alpha and kill-zero nemesis. (cherry picked from commit 9293c97)
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 18, 2020
The grpcWorker.ServeTask function is called when a request is received over the network (sent by a peer). This function doesn't consider the health of the node before starting the processing of the request. If we process a request before the node is ready, we might end up seeing crashes similar to https://dgraph.atlassian.net/browse/DGRAPH-1934 Fixes DGRAPH-1934 This bug was seen when running jepsen bank test with kill-alpha and kill-zero nemesis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The grpcWorker.ServeTask function is called when a request is received
over the network (sent by a peer). This function doesn't consider the
health of the node before starting the processing of the request. If we
process a request before the node is ready, we might end up seeing
crashes similar to https://dgraph.atlassian.net/browse/DGRAPH-1934
Fixes DGRAPH-1934
I ran jepsen bank test with all nemesis and don't see any panics
This change is