Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(debug): Expose http pprof to debug tool. #6032

Merged
merged 4 commits into from
Dec 4, 2020

Conversation

danielmai
Copy link
Contributor

@danielmai danielmai commented Jul 18, 2020

Expose an HTTP port for pprof when using dgraph debug.


This change is Reviewable

Copy link
Contributor

@ashish-goswami ashish-goswami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @danielmai, @manishrjain, and @vvbalaji-dgraph)


dgraph/cmd/debug/run.go, line 768 at r1 (raw file):

				fmt.Println("Port busy. Trying another one...")
				continue

extra line

@netlify
Copy link

netlify bot commented Dec 4, 2020

Deploy preview for dgraph-docs ready!

Built with commit fc401ea

https://deploy-preview-6032--dgraph-docs.netlify.app

@danielmai danielmai merged commit 206e45f into master Dec 4, 2020
@danielmai danielmai deleted the danielmai/debug-pprof branch December 4, 2020 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants