fix(GraphQL): Fix segmentation fault when calling the /admin/backup endpoint. #6042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndpoint. PR #5802 introduced a bug that caused the adminServer global variable to never be set, which in turned caused a segmentation fault when the /admin/backup endpoint was called. This PR fixes the bug and changes the minio-large test to use the /admin/backup endpoint to act as a regression test. Fixes DGRAPH-1938.
parasssh
approved these changes
Jul 20, 2020
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @manishrjain and @vvbalaji-dgraph)
martinmr
added a commit
that referenced
this pull request
Jul 20, 2020
…ndpoint. (#6042) PR #5802 introduced a bug that caused the adminServer global variable to never be set, which in turned caused a segmentation fault when the /admin/backup endpoint was called. This PR fixes the bug and changes the minio-large test to use the /admin/backup endpoint to act as a regression test. Fixes DGRAPH-1938. (cherry picked from commit 6d01404)
parasssh
pushed a commit
that referenced
this pull request
Jul 20, 2020
…ndpoint. (#6042) (#6043) PR #5802 introduced a bug that caused the adminServer global variable to never be set, which in turned caused a segmentation fault when the /admin/backup endpoint was called. This PR fixes the bug and changes the minio-large test to use the /admin/backup endpoint to act as a regression test. Fixes DGRAPH-1938. (cherry picked from commit 6d01404)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #5802 introduced a bug that caused the adminServer global variable to
never be set, which in turned caused a segmentation fault when the
/admin/backup endpoint was called. This PR fixes the bug and changes the
minio-large test to use the /admin/backup endpoint to act as a
regression test.
Fixes DGRAPH-1938.
This change is