chore: Merge release/v20.07 to release/v20.07-slash #6536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Port GraphQL docs to v20.07 This reverts commit 8db61a3. Co-authored-by: Pawan Rawal <pawan0201@gmail.com>
Passing a few variables to the hugo theme
Co-authored-by: Sankalan Parajuli <sankalan.13@gmail.com>
…6272) (#6276) Currently a node is marked as visited if it's been visited before AND has been visited from the same source UID. In dense graphs, the second condition leads to exponential growth of the data and to other issues such as responses that are too big to encode. Removing this condition fixes the issue. Fixed tests and verified the new output makes sense. Fixes DGRAPH-2337 (cherry picked from commit 3638c12)
Clear out the start_ts field in the postings of deltas before they are marshalled to avoid storing that field in disk. This field is only meant to be used during in-memory processing. Related to https://discuss.dgraph.io/t/start-ts-not-being-cleared-before-postings-are-written-to-disk/9146 (cherry picked from commit fbbd731)
Reference: [Discuss Post](https://discuss.dgraph.io/t/custom-dql-typename-bug-strange-behaviour/9341) (cherry picked from commit 0faae40)
Fixes: #5516 Fixes: [Discuss Issue](https://discuss.dgraph.io/t/graphql-fragments-generates-unexpected-behaviour/7470) (cherry picked from commit dcce8bf)
Fixes DGRAPH-2181 The queries in dgraph are processed in separate goroutines. The pstore badger DB could be closed while the query was being processed. This causes panics such as ``` panic: runtime error: invalid memory address or nil pointer dereference panic: Unclosed iterator at time of Txn.Discard. [signal SIGSEGV: segmentation violation code=0x1 addr=0x10 pc=0x11d2311] goroutine 19298 [running]: github.com/dgraph-io/badger/v2.(*Txn).Discard(0xc05586bc20) /go/pkg/mod/github.com/dgraph-io/badger/v2@v2.0.1-rc1.0.20200718033852-37ee16d8ad1c/txn.go:517 +0xc1 panic(0x19e26a0, 0x2988560) /usr/local/go/src/runtime/panic.go:969 +0x166 github.com/dgraph-io/badger/v2/skl.(*Skiplist).IncrRef(...) ``` This PR attempts to reduce the number of such crashes. This PR doesn't fix the actual issue but it tries to reduce the probability of such crashes by checking if badger is not closed before accessing it. An ideal fix would be to stop all the goroutines started by dgraph while closing DB so that we don't try to read from a closed badger DB. (cherry picked from commit 3cea0fe)
This badger update brings the following changes from badger. https://github.com/dgraph-io/badger/commits/b41e77a Fix(cleanup): Avoid truncating in value.Open on error https://github.com/dgraph-io/badger/commits/a0d4903 fix(cleanup): Do not close cache before compaction
…GQLSchema (#6349) (#6354) * fix(GraphQL): incorrect generatedSchema in updateGQLSchema (#6349) This PR fixes the behaviour where Dgraph schema was being given as generatedSchema field in updateGQLSchema request. Now, the newly generated complete GraphQL schema is given as generatedSchema. (cherry picked from commit 0b8681c) # Conflicts: # graphql/e2e/schema/schema_test.go
) (#6417) Fixes GRAPHQL-655. For this user schema (interface have no non-Id field): ``` interface A { name: String! @id } type B implements A { age: Int! } ``` the following delete mutation ``` mutation{ deleteA(filter:{name:{eq: "xyz"}}){ a{ name } } } ``` was resulting in the following error: ``` { "errors": [ { "message": "Internal Server Error - a panic was trapped. This indicates a bug in the GraphQL server. A stack trace was logged. Please let us know by filing an issue with the stack trace." } ] } ``` This PR fixes this bug and now deleting can be performed successfully. (cherry picked from commit 742259b)
…6424) Fixes GRAPHQL-642. For this restoreStatus query using variable ``` query restoreStatus($restoreId: Int!) { restoreStatus(restoreId: $restoreId) { status errors } } ``` was giving this panic ``` panic: interface conversion: interface {} is json.Number, not int64. ``` Whereas the expected result should be ``` { "data": { "restoreStatus": { "status": "UNKNOWN", "errors": [] } }, "extensions": {} } ``` This PR fixes this panic, Now `resolveStatus` with or without variable works fine. (cherry picked from commit 45afae9)
…ed (#6416) (#6530) While creating the add mutation, we weren't squashing different bits correctly which led to the incorrect mutation being sent to Dgraph. This change modifies the set to append for []interface{} to fix that. Fixes GRAPHQL-679 (cherry picked from commit 816a08f) # Conflicts: # graphql/e2e/common/mutation.go # graphql/e2e/directives/schema.graphql # graphql/e2e/normal/schema.graphql # graphql/resolve/schema.graphql
…imanyu/release-slash-merge # Conflicts: # dgraph/cmd/alpha/run.go # edgraph/server.go # go.mod # go.sum # graphql/e2e/common/common.go # graphql/e2e/common/mutation.go # graphql/e2e/directives/schema.graphql # graphql/e2e/directives/schema_response.json # graphql/e2e/normal/schema.graphql # graphql/e2e/normal/schema_response.json # graphql/e2e/schema/generatedSchema.graphql # graphql/e2e/schema/schema_test.go # graphql/resolve/schema.graphql # graphql/schema/wrappers.go # protos/pb/pb.pb.go
…imanyu/release-slash-merge
abhimanyusinghgaur
requested review from
danielmai,
manishrjain,
martinmr,
MichaelJCompton,
pawanrawal and
vvbalaji-dgraph
as code owners
|
|
github-actions
bot
added
area/bulk-loader
abhimanyusinghgaur
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge
release/v20.07-slashwithrelease/v20.07.This change is
Docs Preview: