Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release/v1.2 - fix(worker): Avoid panic in handleUidPostings (#6607) #6699

Merged
merged 1 commit into from
Nov 2, 2020
Merged

release/v1.2 - fix(worker): Avoid panic in handleUidPostings (#6607) #6699

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions worker/task.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,6 +609,18 @@ func (qs *queryState) handleUidPostings(
return nil
}

// srcFn.n should be equal to len(q.UidList.Uids) for below implementation(DivideAndRule and
// calculate) to work correctly. But we have seen some panics while forming DataKey in
// calculate(). panic is of the form "index out of range [4] with length 1". Hence return error
// from here when srcFn.n != len(q.UidList.Uids).
switch srcFn.fnType {
case notAFunction, compareScalarFn, hasFn, uidInFn:
if srcFn.n != len(q.UidList.GetUids()) {
return errors.Errorf("srcFn.n: %d is not equal to len(q.UidList.Uids): %d, srcFn: %+v in "+
"handleUidPostings", srcFn.n, len(q.UidList.GetUids()), srcFn)
}
}

// Divide the task into many goroutines.
numGo, width := x.DivideAndRule(srcFn.n)
x.AssertTrue(width > 0)
Expand Down