Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GraphQL): fix between filter bugs #6822

Merged
merged 3 commits into from
Nov 3, 2020
Merged

Conversation

minhaj-shakeel
Copy link
Contributor

@minhaj-shakeel minhaj-shakeel commented Nov 2, 2020

Fixes GRAPHQL-786.

This PR enforces non-null values for min and max in the between filter.


This change is Reviewable

@github-actions github-actions bot added the area/graphql Issues related to GraphQL support on Dgraph. label Nov 2, 2020
Copy link
Contributor

@pawanrawal pawanrawal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 48 files at r1.
Reviewable status: 4 of 48 files reviewed, all discussions resolved (waiting on @MichaelJCompton and @pawanrawal)

@minhaj-shakeel minhaj-shakeel merged commit be919e5 into master Nov 3, 2020
@minhaj-shakeel minhaj-shakeel deleted the minhaj/fix-between branch November 3, 2020 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/graphql Issues related to GraphQL support on Dgraph.
Development

Successfully merging this pull request may close these issues.

2 participants