fix(DQL): ignore ordering of indexes in schema with eq function (DGRAPH-2601) #6996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhimanyusinghgaur
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
|
Deploy preview for dgraph-docs ready! Built with commit 023dae1 |
abhimanyusinghgaur
requested review from
danielmai and
MichaelJCompton
as code owners
pawanrawal
approved these changes
Nov 26, 2020
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, 2 of 2 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @danielmai, @manishrjain, @MichaelJCompton, and @vvbalaji-dgraph)
OmarAyo
pushed a commit
that referenced
this pull request
Dec 1, 2020
…PH-2601) (#6996) Fixes DGRAPH-2601 Previously, the following schema: ``` name: string @Index(trigram, term) . ``` with some added data, and the following query: ``` query { q(func: eq(name, "Alice", "Bob")) { uid name } } ``` would error out saying it doesn't have a valid tokenizer: ``` { "errors": [ { "message": ": Attribute name does not have a valid tokenizer.", "extensions": { "code": "ErrorInvalidRequest" } } ], "data": null } ``` even though `term` index is present on the predicate. On the other hand, if you reversed the order of indexes: ``` name: string @Index(term, trigram) . ``` It would give correct results: ``` { "data": { "q": [ { "uid": "0x2", "name": "Alice", "age": 20 }, { "uid": "0x3", "name": "Bob", "age": 25 } ] } } ``` This PR fixes the above issue. (cherry picked from commit 0b11439)
OmarAyo
pushed a commit
that referenced
this pull request
Dec 1, 2020
…PH-2601) (#6996) Fixes DGRAPH-2601 Previously, the following schema: ``` name: string @Index(trigram, term) . ``` with some added data, and the following query: ``` query { q(func: eq(name, "Alice", "Bob")) { uid name } } ``` would error out saying it doesn't have a valid tokenizer: ``` { "errors": [ { "message": ": Attribute name does not have a valid tokenizer.", "extensions": { "code": "ErrorInvalidRequest" } } ], "data": null } ``` even though `term` index is present on the predicate. On the other hand, if you reversed the order of indexes: ``` name: string @Index(term, trigram) . ``` It would give correct results: ``` { "data": { "q": [ { "uid": "0x2", "name": "Alice", "age": 20 }, { "uid": "0x3", "name": "Bob", "age": 25 } ] } } ``` This PR fixes the above issue. (cherry picked from commit 0b11439)
OmarAyo
added a commit
that referenced
this pull request
Dec 1, 2020
OmarAyo
added a commit
that referenced
this pull request
Dec 3, 2020
…PH-2601) (#6996) (#7033) Fixes DGRAPH-2601 Previously, the following schema: ``` name: string @Index(trigram, term) . ``` with some added data, and the following query: ``` query { q(func: eq(name, "Alice", "Bob")) { uid name } } ``` would error out saying it doesn't have a valid tokenizer: ``` { "errors": [ { "message": ": Attribute name does not have a valid tokenizer.", "extensions": { "code": "ErrorInvalidRequest" } } ], "data": null } ``` even though `term` index is present on the predicate. On the other hand, if you reversed the order of indexes: ``` name: string @Index(term, trigram) . ``` It would give correct results: ``` { "data": { "q": [ { "uid": "0x2", "name": "Alice", "age": 20 }, { "uid": "0x3", "name": "Bob", "age": 25 } ] } } ``` This PR fixes the above issue. (cherry picked from commit 0b11439) Co-authored-by: Abhimanyu Singh Gaur <12651351+abhimanyusinghgaur@users.noreply.github.com>
OmarAyo
added a commit
that referenced
this pull request
Dec 3, 2020
OmarAyo
added a commit
that referenced
this pull request
Dec 21, 2020
…PH-2601) (#6996) (#7035) Fixes DGRAPH-2601 Previously, the following schema: ``` name: string @Index(trigram, term) . ``` with some added data, and the following query: ``` query { q(func: eq(name, "Alice", "Bob")) { uid name } } ``` would error out saying it doesn't have a valid tokenizer: ``` { "errors": [ { "message": ": Attribute name does not have a valid tokenizer.", "extensions": { "code": "ErrorInvalidRequest" } } ], "data": null } ``` even though `term` index is present on the predicate. On the other hand, if you reversed the order of indexes: ``` name: string @Index(term, trigram) . ``` It would give correct results: ``` { "data": { "q": [ { "uid": "0x2", "name": "Alice", "age": 20 }, { "uid": "0x3", "name": "Bob", "age": 25 } ] } } ``` This PR fixes the above issue. (cherry picked from commit 0b11439) Co-authored-by: Abhimanyu Singh Gaur <12651351+abhimanyusinghgaur@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DGRAPH-2601
Previously, the following schema:
with some added data, and the following query:
would error out saying it doesn't have a valid tokenizer:
even though
termindex is present on the predicate.On the other hand, if you reversed the order of indexes:
It would give correct results:
This PR fixes the above issue.
This change is