chore(test): Refactor GraphQL tests to use best practices (GRAPHQL-885) #7016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhimanyusinghgaur
requested review from
manishrjain,
MichaelJCompton,
pawanrawal and
vvbalaji-dgraph
as code owners
github-actions
bot
added
the
area/graphql
|
Deploy preview for dgraph-docs ready! Built with commit 04279d9 |
abhimanyusinghgaur
changed the title
aman-bansal
approved these changes
Dec 2, 2020
There was a problem hiding this comment.
Reviewed 20 of 21 files at r1, 1 of 1 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @manishrjain, @MichaelJCompton, @pawanrawal, and @vvbalaji-dgraph)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following things:
/probe/graphqlresponse which indicate how many time the GraphQL schema has been updated.common.RequireNoGQLErrorsinstead ofrequire.Nilfor verifying that theGraphQLResponsehas no errors.graphql/e2e/admin_auth.With this PR, all the flakiness around GraphQL schema updates should no longer be there.
This change is