Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] : rephrase + added example to query logging section #7032

Merged
merged 2 commits into from
Dec 3, 2020

Conversation

OmarAyo
Copy link
Contributor

@OmarAyo OmarAyo commented Dec 1, 2020

  • rephrased title
  • rephrased -v=3 paragraph
  • added "note" box to highlight the fact that these flags require a restart
  • added example for query logging output

This change is Reviewable

@OmarAyo OmarAyo added the area/documentation Documentation related issues. label Dec 1, 2020
@netlify
Copy link

netlify bot commented Dec 1, 2020

Deploy preview for dgraph-docs ready!

Built with commit 7d40e5c

https://deploy-preview-7032--dgraph-docs.netlify.app

Copy link
Contributor

@danielmai danielmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @danielmai, @MichaelJCompton, and @OmarAyo)


wiki/content/deploy/log-format.md, line 45 at r1 (raw file):

it in JSON-like format

Rephrase to "the original DQL format". Any \t characters would need to be replaced with a tab character too.

Copy link
Contributor

@danielmai danielmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @danielmai, @MichaelJCompton, and @OmarAyo)


wiki/content/deploy/log-format.md, line 35 at r1 (raw file):

it self

itselff

Copy link
Contributor

@danielmai danielmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @danielmai, @MichaelJCompton, and @OmarAyo)


wiki/content/deploy/log-format.md, line 35 at r1 (raw file):

Previously, danielmai (Daniel Mai) wrote…
it self

itselff

itself*

Copy link
Contributor Author

@OmarAyo OmarAyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @danielmai and @MichaelJCompton)


wiki/content/deploy/log-format.md, line 35 at r1 (raw file):

Previously, danielmai (Daniel Mai) wrote…

itself*

Done.


wiki/content/deploy/log-format.md, line 45 at r1 (raw file):

Previously, danielmai (Daniel Mai) wrote…
it in JSON-like format

Rephrase to "the original DQL format". Any \t characters would need to be replaced with a tab character too.

Done.

Copy link
Contributor

@danielmai danielmai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @danielmai and @MichaelJCompton)

@OmarAyo OmarAyo merged commit bc41f51 into master Dec 3, 2020
@OmarAyo OmarAyo deleted the omar/vmodule-examples branch December 3, 2020 18:14
OmarAyo added a commit that referenced this pull request Dec 7, 2020
* rephrase + added expample to query logging

* rephrase + typos

(cherry picked from commit bc41f51)
OmarAyo added a commit that referenced this pull request Dec 7, 2020
…7078)

* rephrase + added expample to query logging

* rephrase + typos

(cherry picked from commit bc41f51)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Documentation related issues.
Development

Successfully merging this pull request may close these issues.

2 participants