fix(enterprise): Set version correctly post marshalling during restor… #7045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#7018) * Add test for old restore to a cluster * Fix author query * fix(restore): Use correct version after marshalling The marshalPostingList function returns a KV without the version set and this causes issues if you restore a backup on top of an existing data. This PR fixes this issue by explicitly setting the version for the KV returned by the MarshalPostingList function. * Fix test for restoring old backup incremental * Address review comments * Add old backup dir * Add wait for restore, address review comments * Make test use tls, refactor out waitforrestore Co-authored-by: Ibrahim Jarif <ibrahim@dgraph.io>
rahulgurnani
requested review from
danielmai,
manishrjain,
martinmr and
vvbalaji-dgraph
as code owners
|
Deploy preview for dgraph-docs ready! Built with commit 656c651 |
jarifibrahim
approved these changes
Dec 2, 2020
The added directory is used in systest/backup/filesystem/docker-compose.yml.
danielmai
approved these changes
Dec 3, 2020
There was a problem hiding this comment.
Reviewed 9 of 10 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @manishrjain, @martinmr, and @vvbalaji-dgraph)
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e (#7018)
Add test for old restore to a cluster
Fix author query
fix(restore): Use correct version after marshalling
The marshalPostingList function returns a KV without the version set and
this causes issues if you restore a backup on top of an existing data.
This PR fixes this issue by explicitly setting the version for the KV
returned by the MarshalPostingList function.
Fix test for restoring old backup incremental
Address review comments
Add old backup dir
Add wait for restore, address review comments
Make test use tls, refactor out waitforrestore
Co-authored-by: Ibrahim Jarif ibrahim@dgraph.io
This change is