Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metric): Add dgraph_memory_alloc_bytes to track jemalloc memory. #7051

Merged
merged 4 commits into from
Dec 3, 2020

Conversation

danielmai
Copy link
Contributor

@danielmai danielmai commented Dec 3, 2020

This adds a new metric called dgraph_memory_alloc_bytes that tracks the jemalloc memory reported by z.NumAllocBytes().

Changes

  • Add dgraph_memory_alloc_bytes Prometheus metric.
  • Add comment about runtime.ReadMemStats stopping the world.

This change is Reviewable

@netlify
Copy link

netlify bot commented Dec 3, 2020

Deploy preview for dgraph-docs ready!

Built with commit 0078f64

https://deploy-preview-7051--dgraph-docs.netlify.app

@danielmai danielmai changed the title feat(metric): Add dgraph_memory_alloc_bytes. feat(metric): Add dgraph_memory_alloc_bytes to track jemalloc memory. Dec 3, 2020
Copy link
Contributor

@darkn3rd darkn3rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @manishrjain and @vvbalaji-dgraph)

Copy link
Contributor

@darkn3rd darkn3rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 2 files reviewed, all discussions resolved (waiting on @darkn3rd, @manishrjain, and @vvbalaji-dgraph)

@danielmai danielmai merged commit cadf448 into master Dec 3, 2020
@danielmai danielmai deleted the danielmai/metrics-num-alloc branch December 3, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants