Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(debug): Support rollup in debug tool #7066

Merged
merged 5 commits into from
Dec 4, 2020
Merged

feat(debug): Support rollup in debug tool #7066

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d713f87
feat(debug): Support rollup in debug tool
Dec 4, 2020
c6381f7
fixup
Dec 4, 2020
fe6f435
add review comments
Dec 4, 2020
ef629c2
break from for loop
Dec 4, 2020
62d8630
Address review comments
Dec 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 43 additions & 1 deletion dgraph/cmd/debug/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@ var (
type flagOptions struct {
vals bool
keyLookup string
rollupKey string
keyHistory bool
predicate string
readOnly bool
Expand Down Expand Up @@ -93,6 +94,7 @@ func init() {
flag.BoolVarP(&opt.readOnly, "readonly", "o", true, "Open in read only mode.")
flag.StringVarP(&opt.predicate, "pred", "r", "", "Only output specified predicate.")
flag.StringVarP(&opt.keyLookup, "lookup", "l", "", "Hex of key to lookup.")
flag.StringVar(&opt.rollupKey, "rollup", "", "Hex of key to rollup.")
flag.BoolVarP(&opt.keyHistory, "history", "y", false, "Show all versions of a key.")
flag.StringVarP(&opt.pdir, "postings", "p", "", "Directory where posting lists are stored.")
flag.BoolVar(&opt.sizeHistogram, "histogram", false,
Expand Down Expand Up @@ -441,6 +443,43 @@ func appendPosting(w io.Writer, o *pb.Posting) {
}
fmt.Fprintln(w, "")
}
func rollupKey(db *badger.DB) {
txn := db.NewTransactionAt(opt.readTs, false)
defer txn.Discard()

key, err := hex.DecodeString(opt.rollupKey)
x.Check(err)

iopts := badger.DefaultIteratorOptions
iopts.AllVersions = true
iopts.PrefetchValues = false
itr := txn.NewKeyIterator(key, iopts)
defer itr.Close()

itr.Rewind()
if !itr.Valid() {
log.Fatalf("Unable to seek to key: %s", hex.Dump(key))
}

item := itr.Item()
// Don't need to do anything if the bitdelta is not set.
if item.UserMeta()&posting.BitDeltaPosting == 0 {
fmt.Printf("First item has UserMeta:[b%04b]. Nothing to do\n", item.UserMeta())
return
}
pl, err := posting.ReadPostingList(item.KeyCopy(nil), itr)
x.Check(err)

alloc := z.NewAllocator(32 << 20)
defer alloc.Release()

kvs, err := pl.Rollup(alloc)
x.Check(err)

wb := db.NewManagedWriteBatch()
x.Check(wb.WriteList(&bpb.KVList{Kv: kvs}))
x.Check(wb.Flush())
}

func lookup(db *badger.DB) {
txn := db.NewTransactionAt(opt.readTs, false)
Expand Down Expand Up @@ -543,6 +582,7 @@ func printKeys(db *badger.DB) {
}

var sz, deltaCount int64
LOOP:
for ; itr.ValidForPrefix(prefix); itr.Next() {
item := itr.Item()
if !bytes.Equal(item.Key(), key) {
Expand All @@ -556,7 +596,7 @@ func printKeys(db *badger.DB) {
// This is rather a default case as one of the 4 bit must be set.
case posting.BitCompletePosting, posting.BitEmptyPosting, posting.BitSchemaPosting:
sz += item.EstimatedSize()
break
break LOOP
case posting.BitDeltaPosting:
sz += item.EstimatedSize()
deltaCount++
Expand Down Expand Up @@ -896,6 +936,8 @@ func run() {
// fmt.Printf("Min commit: %d. Max commit: %d, w.r.t %d\n", min, max, opt.readTs)

switch {
case len(opt.rollupKey) > 0:
rollupKey(db)
case len(opt.keyLookup) > 0:
lookup(db)
case len(opt.jepsen) > 0:
Expand Down