fix(bulk): Fix memory held by tree in reduce phase #7161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahsanbarkati
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
NamanJain8
approved these changes
Dec 17, 2020
There was a problem hiding this comment.
Approved as per #4738. But we should still figure out the exact cause.
danielmai
pushed a commit
that referenced
this pull request
Dec 21, 2020
Fix memory held by b+ tree even in the reduce phase of bulk loader by bringing back the change #4738.
ahsanbarkati
added a commit
that referenced
this pull request
Jan 19, 2021
NamanJain8
pushed a commit
that referenced
this pull request
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was observed earlier as well and there was a PR fixing it. This PR brings that change back.
#4738
We still need to find the exact cause of why the tree is not GCed without explicitly setting it to nil, despite the parent struct set to nil.
This change is