-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ApolloFederation): Add "_service" resolver #7260
Merged
minhaj-shakeel
merged 31 commits into
minhaj/apollo-federation
from
minhaj/federation-service-resolver
Jan 11, 2021
Merged
feat(ApolloFederation): Add "_service" resolver #7260
minhaj-shakeel
merged 31 commits into
minhaj/apollo-federation
from
minhaj/federation-service-resolver
Jan 11, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minhaj-shakeel
changed the base branch from
master
to
minhaj/apollo-federation
January 8, 2021 07:14
github-actions
bot
added
the
area/graphql
Issues related to GraphQL support on Dgraph.
label
Jan 8, 2021
…io/dgraph into minhaj/federation-service-resolver
abhimanyusinghgaur
approved these changes
Jan 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 5 files at r1, 2 of 3 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @pawanrawal)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes GRAPHQL-934.
This PR adds
_service
resolver according to the federation specs which return generated schema string without @apollo directives to be used by the gateway.The query is:
which returns the schema string.
This change is