Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ApolloFederation): Add "_service" resolver #7260

Merged

Conversation

minhaj-shakeel
Copy link
Contributor

@minhaj-shakeel minhaj-shakeel commented Jan 8, 2021

Fixes GRAPHQL-934.
This PR adds _service resolver according to the federation specs which return generated schema string without @apollo directives to be used by the gateway.
The query is:

query {
   _service {
      sdl
   }
}

which returns the schema string.


This change is Reviewable

@minhaj-shakeel minhaj-shakeel changed the base branch from master to minhaj/apollo-federation January 8, 2021 07:14
@github-actions github-actions bot added the area/graphql Issues related to GraphQL support on Dgraph. label Jan 8, 2021
Copy link
Contributor

@abhimanyusinghgaur abhimanyusinghgaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 5 files at r1, 2 of 3 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @pawanrawal)

@minhaj-shakeel minhaj-shakeel merged commit b674991 into minhaj/apollo-federation Jan 11, 2021
@minhaj-shakeel minhaj-shakeel deleted the minhaj/federation-service-resolver branch January 11, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/graphql Issues related to GraphQL support on Dgraph.
Development

Successfully merging this pull request may close these issues.

2 participants