Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(GRAPHQL):[Breaking] Don't generate get query on interface if it doesn't have field of type ID and also disallow get query on field of type @id in inerface. (#7158) #7305

Merged
merged 1 commit into from
Jan 15, 2021
Merged

fix(GRAPHQL):[Breaking] Don't generate get query on interface if it doesn't have field of type ID and also disallow get query on field of type @id in inerface. (#7158) #7305

merged 1 commit into from
Jan 15, 2021

Commits on Jan 15, 2021

  1. fix(GRAPHQL):[Breaking] Don't generate get query on interface if it d… 

    …oesn't have field of type ID and also disallow get query on field of type @id in inerface. (#7158)

Fixes GRAPHQL-886
We were allowing get query on the field of type @id on the interface type. This causes an error in cases when interface is implemented by multiple types and they try to have same value for field of type @id.
To resolve this we are disallowing get query on the interface if it doesn't have a field of type ID , and if we have both fields of type ID and @id then we don't allow get query on the field of type @id.

(cherry picked from commit 96b1fa5)
    @JatinDev543
    JatinDev543 committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    a0022e4 View commit details
    Browse the repository at this point in the history