Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/v20.11 - fix(ludicrous): Fix logical race in concurrent execution of mutations… #7309

Merged
merged 1 commit into from
Jan 15, 2021
Merged

Release/v20.11 - fix(ludicrous): Fix logical race in concurrent execution of mutations… #7309

merged 1 commit into from
Jan 15, 2021

Conversation

ahsanbarkati
Copy link
Contributor

@ahsanbarkati ahsanbarkati commented Jan 15, 2021 •
edited by manishrjain
Loading

… (#7269)

Fix the logical race condition in the concurrent execution of mutations
in the ludicrous mode. The issue caused same mutation to be called
for execution twice, which resulted in double done on the watermark.

(cherry picked from commit 594ff63)

This change is Reviewable

@ahsanbarkati
fix(ludicrous): Fix logical race in concurrent execution of mutations (…
5385f70 
…#7269)

Fix the race condition in the concurrent execution of mutations in
the ludicrous mode. The issue caused same mutation to be called
for execution twice, which resulted in double done on the watermark.

(cherry picked from commit 594ff63)
jarifibrahim
jarifibrahim approved these changes Jan 15, 2021
View reviewed changes
Copy link
Contributor

@jarifibrahim jarifibrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge after CI passes

@ahsanbarkati ahsanbarkati merged commit 5172efa into release/v20.11 Jan 15, 2021
@ahsanbarkati ahsanbarkati deleted the ahsan/ludicrous-logical-race branch January 15, 2021 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarifibrahim jarifibrahim jarifibrahim approved these changes

@danielmai danielmai Awaiting requested review from danielmai

@manishrjain manishrjain Awaiting requested review from manishrjain

@vvbalaji-dgraph vvbalaji-dgraph Awaiting requested review from vvbalaji-dgraph

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahsanbarkati @jarifibrahim