Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release/v20.11: fix(bulk): Fix memory held by b+ tree in reduce phase (#7161) #7333

Merged
merged 1 commit into from
Jan 19, 2021
Merged

release/v20.11: fix(bulk): Fix memory held by b+ tree in reduce phase (#7161) #7333

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions xidmap/xidmap.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,12 @@ func (m *XidMap) AllocateUid() uint64 {

// Flush must be called if DB is provided to XidMap.
func (m *XidMap) Flush() error {
// While running bulk loader, this method is called at the completion of map phase. After this
// method returns xidmap of bulk loader is made nil. But xidmap still show up in memory profiles
// even during reduce phase. If bulk loader is running on large dataset, this occupies lot of
// memory and causing OOM sometimes. Making shards explicitly nil in this method fixes this.
// TODO: find why xidmap is not getting GCed without below line.
m.shards = nil
if m.writer == nil {
return nil
}
Expand Down