Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(multi-tenancy): update lease Ns ID after restore #7407

Merged
merged 8 commits into from
Feb 10, 2021

Conversation

NamanJain8
Copy link
Contributor

@NamanJain8 NamanJain8 commented Feb 8, 2021

  • Fix bunch of tests.
  • Update lease namespace ID after restore.

This change is Reviewable

Copy link
Contributor

@jarifibrahim jarifibrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 10 files reviewed, 3 unresolved discussions (waiting on @manishrjain, @NamanJain8, and @vvbalaji-dgraph)


ee/backup/run.go, line 239 at r1 (raw file):

		if err := leaseID(result.MaxLeaseUid, pb.Num_UID); err != nil {
			return err

wrap the error please


ee/backup/run.go, line 242 at r1 (raw file):

		}
		if err := leaseID(result.MaxLeaseNsId, pb.Num_NS_ID); err != nil {
			return err

wrap the error please


worker/file_handler.go, line 204 at r1 (raw file):

				maxUid = groupMaxUid
			}
			if groupMaxNsId > maxNsId {

You can also use x.Max(...)

Copy link
Contributor Author

@NamanJain8 NamanJain8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 10 files reviewed, 3 unresolved discussions (waiting on @jarifibrahim, @manishrjain, and @vvbalaji-dgraph)


ee/backup/run.go, line 239 at r1 (raw file):

Previously, jarifibrahim (Ibrahim Jarif) wrote…

wrap the error please

Done.


ee/backup/run.go, line 242 at r1 (raw file):

Previously, jarifibrahim (Ibrahim Jarif) wrote…

wrap the error please

Done.


worker/file_handler.go, line 204 at r1 (raw file):

Previously, jarifibrahim (Ibrahim Jarif) wrote…

You can also use x.Max(...)

Done.

@NamanJain8 NamanJain8 merged commit cd81510 into ibrahim/multitenancy Feb 10, 2021
@NamanJain8 NamanJain8 deleted the naman/multitenancy/fix-tests branch February 10, 2021 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants