-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(multi-tenancy): update lease Ns ID after restore #7407
fix(multi-tenancy): update lease Ns ID after restore #7407
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 10 files reviewed, 3 unresolved discussions (waiting on @manishrjain, @NamanJain8, and @vvbalaji-dgraph)
ee/backup/run.go, line 239 at r1 (raw file):
if err := leaseID(result.MaxLeaseUid, pb.Num_UID); err != nil { return err
wrap the error please
ee/backup/run.go, line 242 at r1 (raw file):
} if err := leaseID(result.MaxLeaseNsId, pb.Num_NS_ID); err != nil { return err
wrap the error please
worker/file_handler.go, line 204 at r1 (raw file):
maxUid = groupMaxUid } if groupMaxNsId > maxNsId {
You can also use x.Max(...)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 10 files reviewed, 3 unresolved discussions (waiting on @jarifibrahim, @manishrjain, and @vvbalaji-dgraph)
ee/backup/run.go, line 239 at r1 (raw file):
Previously, jarifibrahim (Ibrahim Jarif) wrote…
wrap the error please
Done.
ee/backup/run.go, line 242 at r1 (raw file):
Previously, jarifibrahim (Ibrahim Jarif) wrote…
wrap the error please
Done.
worker/file_handler.go, line 204 at r1 (raw file):
Previously, jarifibrahim (Ibrahim Jarif) wrote…
You can also use
x.Max(...)
Done.
This change is