[BREAKING] fix(usability): make force-namespace flag compulsory in live loader for galaxy user #7731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NamanJain8
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
github-actions
bot
added
area/live-loader
NamanJain8
changed the title
jarifibrahim
approved these changes
Apr 16, 2021
NamanJain8
commented
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will be breaking because
--force-namespaceflag was optional for galaxy users earlier.There might be an issue where a user may unknowingly load the data into a default namespace (when she instead wants to preserve a namespace). This can be dangerous. So, this change makes the live loader expects the user to explicitly set the
--force-namespace.This change is