cloud: fix(schema-update): Start opIndexing only when index creation is requ… #7846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ired. (#7845) We were starting opIndexing while schema update irrespective of whether index building is required or not. This caused Dgraph to be unable to create namespaces while backup is running, despite the fact that namespace creation doesn't need any indexing. This PR fixes this issue. (cherry picked from commit 5595f9c)
ahsanbarkati
requested review from
manishrjain and
vvbalaji-dgraph
as code owners
NamanJain8
approved these changes
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ired. (#7845)
We were starting opIndexing while schema update irrespective of whether index
building is required or not. This caused Dgraph to be unable to create namespaces
while backup is running, despite the fact that namespace creation doesn't need
any indexing. This PR fixes this issue.
(cherry picked from commit 5595f9c)
This change is