Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sroar): Fix TestAuthWithCustomDQL failure because of roaring bitmaps #7902

Merged
merged 2 commits into from
Jun 17, 2021

Conversation

ahsanbarkati
Copy link
Contributor

@ahsanbarkati ahsanbarkati commented Jun 16, 2021

We should consider the state of UIdMatrix (whether it was in the form of SortedUids or bitmap) in order to set the result after pagination. Pagination with cascade is handled separately, where it is possible to have no order.


This change is Reviewable

@ahsanbarkati ahsanbarkati marked this pull request as ready for review June 16, 2021 15:42
@ahsanbarkati ahsanbarkati changed the title Fix cascade pagination test failure fix(sroar): Fix TestAuthWithCustomDQL failure because of roaring bitmaps Jun 16, 2021
@ahsanbarkati ahsanbarkati merged commit d628f2e into master Jun 17, 2021
@ahsanbarkati ahsanbarkati deleted the ahsan/fix-pagination-test branch June 17, 2021 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants