Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible fix for t pkg flag #8234

Merged
merged 1 commit into from
Sep 13, 2022
Merged

possible fix for t pkg flag #8234

merged 1 commit into from
Sep 13, 2022

Conversation

dshekhar95
Copy link
Contributor

Problem

when using the --pkg flag running tests thru t locally, currently it takes any suffix match.
ex. if i set --pkg=auth, it will run tests not only for auth but also for admin_auth

Solution

Add a "/" before the suffix check to ensure only full pkg name works

@dshekhar95 dshekhar95 marked this pull request as ready for review September 6, 2022 21:07
Copy link
Contributor

@skrdgraph skrdgraph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 👍

PS: I'll merge this - after other PRs have gotten in (working on some listing PRs, will merge this one later in the evening)

@skrdgraph skrdgraph merged commit a12bf95 into main Sep 13, 2022
@skrdgraph skrdgraph deleted the dshekhar95/fix-t-pkg-check branch September 13, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants