Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(test): adding logging to HttpLogin function #8350

Merged
merged 2 commits into from
Oct 4, 2022
Merged

fix(test): adding logging to HttpLogin function #8350

merged 2 commits into from
Oct 4, 2022

Conversation

skrdgraph
Copy link
Contributor

@skrdgraph skrdgraph commented Oct 4, 2022 •
edited
Loading

Problem

need logging for identifying flaky test issue with restore

Solution

super verbose logging

@skrdgraph skrdgraph changed the title logging fix(test): adding logging to HttpLogin function Oct 4, 2022
@coveralls
Copy link

coveralls commented Oct 4, 2022 •
edited
Loading

Coverage Status

Coverage decreased (-0.004%) to 37.18% when pulling 082b9a1 on skrdgraph/test_logging into a80c643 on main.

@skrdgraph skrdgraph marked this pull request as ready for review October 4, 2022 22:49
@dshekhar95 dshekhar95 self-requested a review October 4, 2022 22:52
@skrdgraph skrdgraph merged commit e781d1f into main Oct 4, 2022
@skrdgraph skrdgraph deleted the skrdgraph/test_logging branch October 4, 2022 23:28
joshua-goldstein pushed a commit that referenced this pull request Oct 16, 2022
@skrdgraph @joshua-goldstein
fix(test): adding logging to HttpLogin function (#8350)
e4d3c01 
## Problem
need logging for identifying flaky test issue with `restore`

## Solution
super verbose logging
joshua-goldstein pushed a commit that referenced this pull request Oct 17, 2022
@skrdgraph @joshua-goldstein
fix(test): adding logging to HttpLogin function (#8350)
cdedc3b 
## Problem
need logging for identifying flaky test issue with `restore`

## Solution
super verbose logging
joshua-goldstein pushed a commit that referenced this pull request Nov 4, 2022
@skrdgraph @joshua-goldstein
fix(test): adding logging to HttpLogin function (#8350)
e3fd3a4 
## Problem
need logging for identifying flaky test issue with `restore`

## Solution
super verbose logging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dshekhar95 dshekhar95 dshekhar95 approved these changes

@akon-dey akon-dey Awaiting requested review from akon-dey

@gcxml gcxml Awaiting requested review from gcxml

@darkn3rd darkn3rd Awaiting requested review from darkn3rd

@meghalims meghalims Awaiting requested review from meghalims

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@skrdgraph @coveralls @dshekhar95