chore(test): Integrate LDBC Tests into CI Workflow #8367
Conversation
all-seeing-code
requested review from
akon-dey,
gcxml,
skrdgraph,
darkn3rd and
meghalims
as code owners
|
|
all-seeing-code
changed the title
|
@anurags92 - you can mark a WIP PR as |
all-seeing-code
force-pushed
the
anurag/integrate-ldbc-to-ci
branch
from
879d3a2
to
87ffb54
Compare
- Add a different workflow for ldbc tests
all-seeing-code
force-pushed
the
anurag/integrate-ldbc-to-ci
branch
from
819e685
to
e8c1c5a
Compare
all-seeing-code
requested review from
matthewmcneely and
billprovince
as code owners
| @@ -832,6 +903,9 @@ func run() error { | |||
| if *suite == "load" || *suite == "all" { | |||
| downloadDataFiles() | |||
| } | |||
| if *suite == "ldbc" || *suite == "all" { | |||
| downloadLDBCFiles() | |||
There was a problem hiding this comment.
Is this an expensive operation? If testing locally, maybe it should check for the existence of the LDBC files in downloadLDBCFiles?
There was a problem hiding this comment.
It does have a flag downloadResources which when passed as false will not download the resources again. This is used in load-tests as well.
There was a problem hiding this comment.
PR looks good @anurags92 - only small nitpick, we made some changes to the workflow files (some cleanup). You can see the setup here.
Main differences:
- Get Go version from .go-version file
- Use
make docker-imageinstead ofmake image-local(which automatically builds Dgraph binary, no need to callmake dgraphseparately, and no architecture specific arguments given)
all-seeing-code
changed the title
| desc := tt.Tag | ||
| // TODO(anurag): IC06 and IC10 have non-deterministic results because of dataset. | ||
| // Find a way to modify the queries to include them in the tests | ||
| if desc == "IC06" || desc == "IC10" { |
There was a problem hiding this comment.
Query IC06 and IC10 can have multiple correct answers based on the indexing. Will have to modify the queries to get deterministic results. Added a TODO.
PR integrates LDBC tests as a CI/CD workflow.
Query descriptions can be found at https://ldbcouncil.org/ldbc_snb_docs/ldbc-snb-specification.pdf