Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick namespace aware drop data #8511

Merged
merged 1 commit into from
Jan 24, 2023
Merged

Cherry-pick namespace aware drop data #8511

merged 1 commit into from
Jan 24, 2023

Conversation

all-seeing-code
Copy link
Contributor

@all-seeing-code all-seeing-code commented Dec 13, 2022 •
edited by rderbier
Loading

fixes #8521

@CLAassistant
Copy link

CLAassistant commented Dec 13, 2022 •
edited
Loading

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added area/bulk-loader Issues related to bulk loading. area/enterprise Related to proprietary features area/graphql Issues related to GraphQL support on Dgraph. area/live-loader Issues related to live loading. area/testing Testing related issues labels Dec 13, 2022
@all-seeing-code all-seeing-code changed the title WIP WIP: Cherry-pick namespace aware drop data Dec 13, 2022
@all-seeing-code all-seeing-code changed the base branch from main to aman/cp December 13, 2022 14:21
@all-seeing-code all-seeing-code added the slash-to-main PRs which bring slash branch on par with main. label Dec 13, 2022
@mangalaman93 mangalaman93 changed the base branch from aman/cp to aman/async January 2, 2023 12:07
@mangalaman93 mangalaman93 marked this pull request as ready for review January 2, 2023 12:08
@mangalaman93 mangalaman93 added this to the v23.0.0 milestone Jan 11, 2023
matthewmcneely
matthewmcneely previously approved these changes Jan 17, 2023
View reviewed changes
harshil-goel
harshil-goel previously approved these changes Jan 20, 2023
View reviewed changes
Base automatically changed from aman/async to main January 23, 2023 11:47
@NamanJain8 @mangalaman93
fix(backup): make drop data namespace aware
6c16b0b 
cherry-picks:
  * 260a789: This commit
    makes DropData namespace-aware in a multi-tenant system.
    Now, guardians of a namespace can call drop data on their
    namespace. Earlier only the guardian of the galaxy was
    allowed to do cluster-wide drop operation.

  * 7981a4d: use galaxynamespace
    when restore from old backup
@coveralls
Copy link

Coverage Status

Coverage: 67.126% (+0.1%) from 67.008% when pulling 6c16b0b on anurag/cherry-pick-drop-data into d3bf7b7 on main.

harshil-goel
harshil-goel approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@harshil-goel harshil-goel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add some tests for restore flow also. For now, we can just add it in the list of tests.

@mangalaman93 mangalaman93 merged commit 5bbea2f into main Jan 24, 2023
@mangalaman93 mangalaman93 deleted the anurag/cherry-pick-drop-data branch January 24, 2023 10:12
all-seeing-code added a commit that referenced this pull request Feb 8, 2023
@all-seeing-code
Cherry-pick namespace aware drop data (#8511)
02112ac 
fixes #8521
skrdgraph added a commit that referenced this pull request Mar 1, 2023
@skrdgraph
move #8511 to added
1d9be61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@harshil-goel harshil-goel harshil-goel approved these changes

@mangalaman93 mangalaman93 mangalaman93 approved these changes

@matthewmcneely matthewmcneely matthewmcneely left review comments

@akon-dey akon-dey Awaiting requested review from akon-dey

@skrdgraph skrdgraph Awaiting requested review from skrdgraph

@darkn3rd darkn3rd Awaiting requested review from darkn3rd

@meghalims meghalims Awaiting requested review from meghalims

@billprovince billprovince Awaiting requested review from billprovince

@MichelDiz MichelDiz Awaiting requested review from MichelDiz

Assignees

@mangalaman93 mangalaman93

Labels
area/bulk-loader Issues related to bulk loading. area/enterprise Related to proprietary features area/graphql Issues related to GraphQL support on Dgraph. area/live-loader Issues related to live loading. area/testing Testing related issues slash-to-main PRs which bring slash branch on par with main.
Milestone
v23.0.0
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT]: guardians can drop data on their namespace
7 participants
@all-seeing-code @CLAassistant @coveralls @matthewmcneely @mangalaman93 @harshil-goel @NamanJain8