chore(test): add layout for dgraphtest package #8707
Conversation
mangalaman93
force-pushed
the
aman/upgrade
branch
7 times, most recently
from
aa6d38a
to
7de7bf6
Compare
mangalaman93
requested review from
akon-dey,
skrdgraph,
darkn3rd,
meghalims,
matthewmcneely and
billprovince
as code owners
shivaji-kharse
force-pushed
the
aman/upgrade
branch
from
7de7bf6
to
f2fe60d
Compare
contrib/Dockerfile
Outdated
| @@ -29,8 +29,6 @@ RUN apt-get update && apt-get install -y --no-install-recommends \ | |||
|
|
|||
| ADD linux /usr/local/bin | |||
|
|
|||
| EXPOSE 8080 | |||
| EXPOSE 9080 | |||
There was a problem hiding this comment.
This is the same Dockerfile that is being used for build, test & release. This could break things for folks who run the image without port-mapping. https://stackoverflow.com/a/22150099 #2 is important.
There was a problem hiding this comment.
If someone is running a Dgraph Cluster, I am wondering how only exposing alpha ports will make things work. We are not exposing zero ports here.
|
@mangalaman93 this may be redundant, I understand the purpose of this. But have you looked at https://github.com/dgraph-io/dgraph/blob/main/compose/compose.go ... The old team (from what I can tell) was planning to transition |
|
The compose tool gives you a very static cluster. For our testing going forward, we would like a more dynamic control on the cluster. Think about upgrades for example, we want to setup a cluster with a dgraph version for which we don't even have a docker image. This could be easily done if we have the binary and we can mount that binary inside the container. We can also do the same when we want to upgrade the cluster and so on. This is just the base of the work, we are going to build more interesting tools on top of this work. I am also thinking that using the same library, we could setup cluster on AWS, ECS if needed and even a cluster on Dgraph cloud. The interface to the test would be consistent so that the same test could run in different environment. Maybe, we could integrate the compose tool as one of the ways of setting up the cluster in the library. |
contrib/Dockerfile
Outdated
| @@ -29,8 +29,6 @@ RUN apt-get update && apt-get install -y --no-install-recommends \ | |||
|
|
|||
| ADD linux /usr/local/bin | |||
|
|
|||
| EXPOSE 8080 | |||
There was a problem hiding this comment.
Why are we removing this?
There was a problem hiding this comment.
because it only works for alpha, it doesn't work for Zero
dgraphtest/cluster.go
Outdated
| return resp.ID, nil | ||
| } | ||
|
|
||
| func (c *Cluster) healthCheck() error { |
There was a problem hiding this comment.
Is checking for health the same as checking if license is applied? Today we got an issue where we were checking for health, but still license failed. Can we add a check for is license applied? Okay to be done in a separate diff.
There was a problem hiding this comment.
could you elaborate?
mangalaman93
force-pushed
the
aman/upgrade
branch
from
0b367d7
to
777353d
Compare
mangalaman93
force-pushed
the
aman/upgrade
branch
from
3242e2b
to
f17bcc9
Compare
This package will provide functions to setup cluster for testing and benchmarking going forward