Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e tests by removing flag for enterprise features. #109

Merged
merged 1 commit into from
Aug 30, 2019

Conversation

danielmai
Copy link
Contributor

@danielmai danielmai commented Aug 30, 2019

dgraph-io/dgraph#3824 removed the --enterprise_features flag. This change removes the flag from the cluster configuration for e2e tests so that the Dgraph cluster can run properly for the tests.


This change is Reviewable

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ A review job has been created and sent to the PullRequest network.


Check the status or cancel PullRequest code review here.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no change requests here - pretty straightforward.

I did have a question regarding the --enterprise-features flag though. It seems to me you'd want this enabled on your prod instance right? Can you provide me some insight into this (mostly for curiosity)


Reviewed with ❤️ by PullRequest

@danielmai
Copy link
Contributor Author

I did have a question regarding the --enterprise-features flag though. It seems to me you'd want this enabled on your prod instance right? Can you provide me some insight into this (mostly for curiosity)

Enterprise features will be enabled on a trial basis for release builds without the flag.

@danielmai danielmai merged commit 7b012bc into master Aug 30, 2019
@danielmai danielmai deleted the danielmai/test-remove-enterprise-flag branch August 30, 2019 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant