Fix build with GOOS=js GOARCH=wasm #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
paralin
added a commit
to paralin/badger
that referenced
this pull request
Feb 21, 2024
Fixes the following build failures: GOOS=js GOARCH=wasm go build ./... GOOS=wasip1 GOARCH=wasm go build ./... Depends on: dgraph-io/ristretto#375 Signed-off-by: Christian Stewart <christian@aperture.us>
paralin
added a commit
to paralin/badger
that referenced
this pull request
May 4, 2024
Fixes the following build failures: GOOS=js GOARCH=wasm go build ./... GOOS=wasip1 GOARCH=wasm go build ./... Depends on: dgraph-io/ristretto#375 Signed-off-by: Christian Stewart <christian@aperture.us>
|
This PR has been stale for 60 days and will be closed automatically in 7 days. Comment to keep it open. |
|
Still relevant |
GOOS=js GOARCH=wasm gb ./... Previously failed with errors importing x/sys/unix. Fixed by adding the appropriate build tags. Signed-off-by: Christian Stewart <christian@aperture.us>
harshil-goel
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GOOS=js GOARCH=wasm gb ./...
Previously failed with errors importing x/sys/unix.
Fixed by adding the appropriate build tags.