Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch to prevent push-receiver crash on disconnect #1540

Merged
merged 2 commits into from
Dec 2, 2024
Merged

Catch to prevent push-receiver crash on disconnect #1540

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f6e91c
Catch to prevent push-receiver crash on disconnect
Nov 25, 2024
6da6aee
Add changeset
dgreif Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages/ring-client-api/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,17 @@ export class RingApi extends Subscribed {
}
}),
)
pushReceiver.on('ON_DISCONNECT', () => {
pushReceiver.whenReady.catch((e) => {
logError(
'Connection to the push notification server has failed unexpectedly',
)
logError(
'If this happens repeatedly, verify connections to TCP/5228 are allowed and that DNS Adblock rules allow gtalk.google.com',
)
logError(e.message)
})
})

try {
await pushReceiver.connect()
Expand Down